Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add Norwegian stores #1985

Merged
merged 5 commits into from Feb 18, 2021
Merged

feat(store): add Norwegian stores #1985

merged 5 commits into from Feb 18, 2021

Conversation

davols
Copy link
Contributor

@davols davols commented Feb 17, 2021

Added Elkjop.no, komplett.no, dustinhome.no, power.no and proshop.no norwegian shops.
Komplett, Dustin (DustinHome) and Power also exists in Sweden, hence the No/.no suffix.

Description

Right now I've only been interested in 3080s so that's what I've added so far. They are all out of stock but 'IN STOCK' have been tested by other random products in each webshop.

Testing

Tested out of stock and in stock (in stock by using random other product link) for all new webshops. Tried to get maxprice to work but failed.

@davols davols requested a review from jef as a code owner February 17, 2021 22:06
@davols davols changed the title Add Norwegian stores elkjop, komplett, dustin, power and proshop feat: Add Norwegian stores elkjop, komplett, dustin, power and proshop Feb 17, 2021
@davols davols changed the title feat: Add Norwegian stores elkjop, komplett, dustin, power and proshop feat: Add Norwegian stores elkjop.no, komplett.no, dustinhome.no, power.no and proshop.no Feb 17, 2021
jef
jef previously approved these changes Feb 18, 2021
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@jef
Copy link
Owner

jef commented Feb 18, 2021

Do you mind adding the stores to the docs/?

@jef jef dismissed their stale review February 18, 2021 14:13

Needs documentation

@davols
Copy link
Contributor Author

davols commented Feb 18, 2021

Do you mind adding the stores to the docs/?

Just update filter.md with the new stores and environment variables or something more?

@davols davols requested a review from jef February 18, 2021 14:21
@jef
Copy link
Owner

jef commented Feb 18, 2021

Do you mind adding the stores to the docs/?

Just update filter.md with the new stores and environment variables or something more?

Nope! Good to go!

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ☺️

@jef jef changed the title feat: Add Norwegian stores elkjop.no, komplett.no, dustinhome.no, power.no and proshop.no feat(store): add Norwegian stores Feb 18, 2021
@jef jef merged commit 5a5927b into jef:main Feb 18, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Adds elkjop.no, komplett.no, dustinhome.no, power.no and proshop.no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants