Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon-ca): out of stock check was missing #1885

Merged
merged 2 commits into from Feb 5, 2021
Merged

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Feb 4, 2021

Description

Fixes: #1884

During the testrun of #1851 the errors where not triggered. but i think somehow that the missing outofstockcheck in any store will cause problems at some point.

Testing

Testing done via VPN ( CA ) and directly to find additional issues, after adding out of stock check everything worked fine here.
image

@wofnull wofnull requested a review from jef as a code owner February 4, 2021 23:21
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much @wofnull 🚀 ☺️

@jef jef merged commit 0e65f33 into jef:main Feb 5, 2021
@wofnull wofnull deleted the amazon-ca_patch branch February 5, 2021 08:52
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1851 breaks the code for amazon-ca
2 participants