Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sms): add US Cellular #1874

Merged
merged 2 commits into from Feb 5, 2021
Merged

feat(sms): add US Cellular #1874

merged 2 commits into from Feb 5, 2021

Conversation

jnines
Copy link
Contributor

@jnines jnines commented Feb 4, 2021

Description

Adds USCC to phone carrier options.
First PR, hopefully I'm doing this right.

Testing

Forked/modified/cloned locally. Npm install, nothing broke. Modified dotenv with PHONE_CARRIER=uscc and added phone number, npm run start with no errors. Added test:brand and test:series via WebUI and got a txt message/email/discord alert shortly after. There is a sms.uscc.net but it doesn't work for this.

Add US Cellular to available SMS options.
@jnines jnines requested a review from jef as a code owner February 4, 2021 03:53
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Looks good to me. Thanks for the addition ☺️

@jef jef changed the title feat: add US Cellular to available SMS options feat(sms): add US Cellular Feb 5, 2021
@jef jef merged commit 4455e4e into jef:main Feb 5, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants