Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): add Streamlabs support #1872

Merged
merged 6 commits into from Feb 9, 2021
Merged

feat(notification): add Streamlabs support #1872

merged 6 commits into from Feb 9, 2021

Conversation

TomZanna
Copy link
Contributor

@TomZanna TomZanna commented Feb 3, 2021

Description

Added the ability to activate alerts via StreamLabs

Requires the user to register with StreamLabs and create an application to request an access token (no need to submit for review).
Useful for sending sound notifications to viewers of a live stream.

Testing

Ran the test notification script

New dependencies

form-data

@TomZanna
Copy link
Contributor Author

TomZanna commented Feb 3, 2021

Over the weekend I will fix the linting problems.
Do you think I could avoid using form-data? I don't like that part of code but it just works.

@TomZanna TomZanna marked this pull request as ready for review February 8, 2021 08:28
@TomZanna TomZanna requested a review from jef as a code owner February 8, 2021 08:28
jef
jef previously approved these changes Feb 9, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query params kind of make sense, but we also didn't make the API! That being said, I feel like authentication shouldn't be sent as a query param, but unfortunately, it is.

Overall, looks good to me!

Thanks for the implementation 😄

jef
jef reviewed Feb 9, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just a couple comments. This is great overall; awesome addition!

docs/reference/notification.md Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/notification/streamlabs.ts Outdated Show resolved Hide resolved
src/notification/streamlabs.ts Show resolved Hide resolved
@jef jef dismissed their stale review February 9, 2021 03:35

Some comments

TomZanna and others added 2 commits February 9, 2021 07:51
@TomZanna @jef
Add unit of measure
ee66ebc 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@TomZanna @jef
Check if the alert type is present
2e86ff0 
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@jef jef changed the title feat: trigger Streamlabs alerts feat(notification): add Streamlabs support Feb 9, 2021
@jef jef merged commit edb39f8 into jef:main Feb 9, 2021
@TomZanna TomZanna deleted the streamlabs branch February 23, 2021 20:33
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@TomZanna @erwinc1
feat(notification): add Streamlabs support (jef#1872)
1b5f7ad
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomZanna @jef