Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon FR - PS5 standard - Alert incorrect #1860

Closed
singsonn opened this issue Feb 2, 2021 · 12 comments
Closed

Amazon FR - PS5 standard - Alert incorrect #1860

singsonn opened this issue Feb 2, 2021 · 12 comments

Comments

@singsonn
Copy link

singsonn commented Feb 2, 2021

Expected Behavior

When scanning for the PS5 console on Amazon FR store, there should currently not be an alert since there is no stock :

Imgur

Current Behavior

However, the link opens to the PS5 camera instead of the PS5 console :

Imgur

Imgur

Steps to Reproduce

Run "npm run start" in MacOS after installing the with "npm install --save node-notifier".

Environment

  • OS: MacOS

relevant dotenv conf:

SHOW_ONLY_MODELS=ps5 console,5900x,founders edition
SHOW_ONLY_SERIES=3060ti,3080,sonyps5c,ryzen5900
STORES=nvidia-fr,amazon-fr,topachat

Logs

[5:30:05 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:05 PM] info :: 🚀🚨 [amazon-fr] [sony (sonyps5c)] ps5 console :: IN STOCK 🚨🚀
https://www.amazon.fr/dp/B08H93ZRK9
[5:30:05 PM] info :: ✔ desktop notification sent
[5:30:05 PM] info :: ✔ telegram message sent
[5:30:07 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK
[5:30:14 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:16 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK
[5:30:18 PM] info :: ✖ [amazon-fr] [amd (ryzen5900)] 5900x :: OUT OF STOCK
[5:30:21 PM] info :: 🚀🚨 [amazon-fr] [sony (sonyps5c)] ps5 console :: IN STOCK 🚨🚀
https://www.amazon.fr/dp/B08H93ZRK9
[5:30:21 PM] info :: ✔ desktop notification sent
[5:30:21 PM] info :: ✔ telegram message sent
[5:30:24 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:26 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK
[5:30:33 PM] info :: ✖ [amazon-fr] [amd (ryzen5900)] 5900x :: OUT OF STOCK
[5:30:35 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:37 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK
[5:30:38 PM] info :: 🚀🚨 [amazon-fr] [sony (sonyps5c)] ps5 console :: IN STOCK 🚨🚀
https://www.amazon.fr/dp/B08H93ZRK9
[5:30:38 PM] info :: ✔ desktop notification sent
[5:30:38 PM] info :: ✔ telegram message sent
[5:30:45 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:46 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK
[5:30:51 PM] info :: ✖ [amazon-fr] [amd (ryzen5900)] 5900x :: OUT OF STOCK
[5:30:57 PM] info :: 🚀🚨 [amazon-fr] [sony (sonyps5c)] ps5 console :: IN STOCK 🚨🚀
https://www.amazon.fr/dp/B08H93ZRK9
[5:30:57 PM] info :: ✔ desktop notification sent
[5:30:57 PM] info :: ✔ telegram message sent
[5:30:58 PM] info :: ✖ [nvidia-fr] [nvidia (3060ti)] founders edition :: OUT OF STOCK
[5:30:59 PM] info :: ✖ [nvidia-fr] [nvidia (3080)] founders edition :: OUT OF STOCK

@ithahn
Copy link

ithahn commented Feb 2, 2021

Same is for Amazon.es!

I guess something was changed on Amazon.. But the Product ID is still the same..

@gigi2006
Copy link

gigi2006 commented Feb 3, 2021

@jef wrote at #1132 that someone could implement the idea with the MIN_Price ... I am unfortunately not able to do this, but maybe someone else here? e.g. @neatchee :)

@jef
Copy link
Owner

jef commented Feb 3, 2021

Same is for Amazon.es!

I guess something was changed on Amazon.. But the Product ID is still the same..

This happens frequently for these items unfortunately.

@SchwarzDeveloping
Copy link

Workaround

labels: {
	inStock: {
		container: '#variation_edition .selection',
		text: ['PS5']
	}
}

@gigi2006
Copy link

gigi2006 commented Feb 5, 2021

Workaround

labels: {
	inStock: {
		container: '#variation_edition .selection',
		text: ['PS5']
	}
}

Can you maybe explain little more?
Or better make a PR?

@SchwarzDeveloping
Copy link

#1893

@gigi2006
Copy link

gigi2006 commented Feb 5, 2021

#1893

Thx Kollege.
Kann man dann wohl auch auf ES umsetzen oder?

My English its Not so good. I ask hin, If we can the same for ES Change :(

@SchwarzDeveloping
Copy link

#1893

Thx Kollege.
Kann man dann wohl auch auf ES umsetzen oder?

My English its Not so good. I ask hin, If we can the same for ES Change :(

Yes. For ES then:
text: ['Consola']

@xkuza
Copy link

xkuza commented Feb 10, 2021

you add this or replace the below?
labels: {
captcha: {
container: 'body',
text: ['entrez les caractères que vous voyez ci-dessous'],
},
inStock: {
container: '#desktop_buybox',
text: ['ajouter au panier'],
},
maxPrice: {
container: '#priceblock_ourprice',
euroFormat: true,
},
outOfStock: [
{
container: '#availability',
text: ['Actuellement indisponible'],
},
],
},

@wazerstar
Copy link

Try run headless=false, you will see any of the fixes mentioned in here does not work and does not select any of the ps5's

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link
Contributor

This issue has been closed because it is stale. Reopen if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants