Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon-ca): update selector #1851

Merged
merged 1 commit into from Feb 2, 2021
Merged

fix(amazon-ca): update selector #1851

merged 1 commit into from Feb 2, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Feb 1, 2021

Description

for maxprice changed for the whole store

Fixes issue #1846

Testing

Local Testing done and verified via CA VPN:

image

@wofnull wofnull requested a review from jef as a code owner February 1, 2021 17:07
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @wofnull 😁

@jef jef merged commit 3293184 into jef:main Feb 2, 2021
@wofnull wofnull deleted the amazon-ca_patch branch February 4, 2021 08:32
@augustynr
Copy link

I am afraid this patch breaks the code, this is the log from a clean install:
[11:32:26 a.m.] info :: ℹ selected stores: amazon-ca
[11:32:26 a.m.] info :: ℹ selected series: 3060ti, 3080
[11:32:26 a.m.] info :: ✔ sound player found: aplay
[11:33:40 a.m.] info :: ✖ [amazon-ca] [msi (3080)] gaming x trio :: OUT OF STOCK
[11:33:47 a.m.] error :: ✖ [amazon-ca] msi 3080 ventus 3x oc - Cannot read property 'join' of null
[11:33:54 a.m.] error :: ✖ [amazon-ca] evga 3080 ftw3 - Cannot read property 'join' of null

@wofnull
Copy link
Contributor Author

wofnull commented Feb 4, 2021

I had the patch up and running for about an hour via VPN before posting this here. There were no errors while testing this.

@MrRobot245
Copy link

I can confirm, getting the same errors for some amazon-ca 3080s - Cannot read property 'join' of null

erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants