Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alternate): update URLs #1814

Merged
merged 2 commits into from Jan 28, 2021
Merged

fix(alternate): update URLs #1814

merged 2 commits into from Jan 28, 2021

Conversation

frommie
Copy link
Contributor

@frommie frommie commented Jan 27, 2021

Fixed the URLs for alternate (de), deleted duplicate entry for PS5 Disc Edition.

Description

Fixes status error code 404 for alternate

Testing

Alternate now returns correct stock status

Delete duplicate entry for PS5 Disc Edition, fixed URLs
@frommie frommie requested a review from jef as a code owner January 27, 2021 15:54
@frommie frommie changed the title fix: correction of alternate links fix: correction of alternate URLs Jan 27, 2021
@frommie
Copy link
Contributor Author

frommie commented Jan 27, 2021

As I see the deleted entry is the bundle so maybe we should leave it

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for fixing ☺️

@jef jef changed the title fix: correction of alternate URLs fix(alternate): update URLs Jan 28, 2021
@jef jef merged commit d63685f into jef:main Jan 28, 2021
@frommie frommie deleted the patch-1 branch January 28, 2021 21:48
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants