Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): corsair-uk #1733

Merged
merged 4 commits into from Jan 19, 2021
Merged

feat(store): corsair-uk #1733

merged 4 commits into from Jan 19, 2021

Conversation

YiIdirim
Copy link
Contributor

Description

  • New UK store variable: corsair-uk.
  • Checks stock for SF600 Gold, SF600/SF750 Platinum.

Testing

  • Checked against out of stock indicator to confirm it is working.
  • Performed robust testing to ensure that it captures the stock correctly.

@YiIdirim YiIdirim requested a review from jef as a code owner January 18, 2021 17:50
jef
jef approved these changes Jan 19, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great addition.

Thanks!

@jef jef merged commit c81282e into jef:main Jan 19, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@YiIdirim @erwinc1
feat(store): corsair-uk (jef#1733)
66a00f5
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YiIdirim @jef @ssaddique