Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia): updated store for europe #1732

Merged
merged 3 commits into from Jan 26, 2021
Merged

feat(nvidia): updated store for europe #1732

merged 3 commits into from Jan 26, 2021

Conversation

YiIdirim
Copy link
Contributor

@YiIdirim YiIdirim commented Jan 18, 2021

Description

Fixes #1393

  • Check stock for all Founders Edition cards in the supported European countries.
  • Removed nvidia-api as it is no longer updated.
  • Updated nvidia with localised store variables, e.g. nvidia-de.

Note: When a card comes into stock, the partner site link is always randomised which means the link is always different every time there is a drop. This PR will notify you when the card comes into stock via the Nvidia store page as opposed to the partner site. This way the correct link is always found.

Please view the issue linked above for detailed information.

Testing

  • Performed robust testing with the new stores.
  • Performed testing when old stores removed.
  • Verified functionality works as expected.

@jef
Copy link
Owner

jef commented Jan 19, 2021

Yeah, this nvidia-api definitely needed to go. I wasn't sure how other regions outside the US were working lately. I'll review this a little later today and hopefully get it in soon enough!

@kakashi84
Copy link

Yeah, this nvidia-api definitely needed to go. I wasn't sure how other regions outside the US were working lately. I'll review this a little later today and hopefully get it in soon enough!

please inser when you can, nvidia-it

@YiIdirim
Copy link
Contributor Author

Yeah, this nvidia-api definitely needed to go. I wasn't sure how other regions outside the US were working lately. I'll review this a little later today and hopefully get it in soon enough!

please inser when you can, nvidia-it

Sorry but Nvidia don't sell the Founders Edition cards in Italy. And I'm pretty sure none of the retailers in Germany or France ship to Italy either.

@kakashi84
Copy link

Yeah, this nvidia-api definitely needed to go. I wasn't sure how other regions outside the US were working lately. I'll review this a little later today and hopefully get it in soon enough!

please inser when you can, nvidia-it

Sorry but Nvidia don't sell the Founders Edition cards in Italy. And I'm pretty sure none of the retailers in Germany or France ship to Italy either.

sorry but there nvidia sold 3070 3080 and 3090 on nvidia.it

@YiIdirim
Copy link
Contributor Author

@kakashi84, I'm afraid you're mistaken. The nvidia store is only used to directly buy the Founders Edition. This PR is for Founders Edition cards only. I checked and verified that Nvidia do not directly sell the Founders Edition cards in Italy.

@kakashi84
Copy link

@kakashi84, I'm afraid you're mistaken. The nvidia store is only used to directly buy the Founders Edition. This PR is for Founders Edition cards only. I checked and verified that Nvidia do not directly sell the Founders Edition cards in Italy.

you are right. but when launch the new generation there is a shop. i control now and the site go to nvidia.es

@jackevans211
Copy link

Hey, guys when do you think this will get added, i set it up myself from this info but what I updated it, there were issues so had to start again?

@YiIdirim
Copy link
Contributor Author

@jef any update on this?

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for doing this. This has been on my mind. Sorry for getting to this late.

I appreciate your help and your contribution! 🚀

@jef jef merged commit 2143b15 into jef:main Jan 26, 2021
@YiIdirim YiIdirim deleted the nvidia-update branch January 26, 2021 12:27
@YiIdirim
Copy link
Contributor Author

Hey, guys when do you think this will get added, i set it up myself from this info but what I updated it, there were issues so had to start again?

It's been merged in. Should work now.

erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate nvidia-api and update nvidia store
5 participants