fix(vuugo): add out of stock check #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jef Looking into this more, in lookup.ts, the order is currently: Check out of stock labels, check max price labels, check in stock labels. This means any store which uses the "instock" label will always show the max price output instead of an out of stock output (In the case of a max price being defined) Perhaps, the ordering should be changed to clarify that the item is infact out of stock prior to the max price message |
patlux
pushed a commit
to patlux/streetmerchant
that referenced
this pull request
Jan 19, 2021
erwinc1
pushed a commit
to erwinc1/streetmerchant
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1716
Checked against the problem case and added the Out of Stock check
Testing
Before:
After:
Works as expected