fix(newegg): false positives (all stores) #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During test run to lockout for new cards on newegg for another fix i do currently prepare, i found that the newegg site ( US / CA / SG ) does give false positives in streetmerchant, showing in Stock items but are in reality out of stock.
Checking against the config file, there was no out of stock check in place and only an instock check, which seemed to hit nothing when cards are not in stock, but still got triggered. Since all 3 sites use the same layout I added ( and tested ) a proper out of stock check.
Testing
Testing has been done, Items out of stock show now proper out of stock and not the listed price / triggering false positives anymore.