Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten best buy urls #1610

Closed
kiowadriver opened this issue Jan 6, 2021 · 1 comment
Closed

Shorten best buy urls #1610

kiowadriver opened this issue Jan 6, 2021 · 1 comment

Comments

@kiowadriver
Copy link

Expected Behavior

The most efficient means of cataloging and updating product URLs

Current Behavior

We are using a more verbose url format than necessary in the bestbuy.ts store model. The BB api has a very very simple url that support both the product page and add cart function.

Examples:

Current URL in bestbuy.ts:
https://www.bestbuy.com/site/evga-geforce-rtx-3070-xc3-black-gaming-8gb-gddr6x-pci-express-4-0-graphics-card/6439300.p?skuId=.....

Shorter version using api:

Tracked Page:
https://api.bestbuy.com/click/-/6439300/pdp

Cart link:
https://api.bestbuy.com/click/-/6439300/cart

@wofnull
Copy link
Contributor

wofnull commented Jan 6, 2021

i have done a patch for this in #1613 , now we wait until jef approves / adds it to the working tree ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants