Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add SG Location for Amazon and Newegg #1600

Merged
merged 13 commits into from Jan 7, 2021

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 5, 2021

Description

Added Singapure Location based upon lawliet89/streetmerchant update ca1564e packing it into an actual feature instead of changing existing files.

Testing

ran script for 5 runs in both stores. Works as intended.

@wofnull wofnull requested a review from jef as a code owner January 5, 2021 13:37
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you very much ☺️ I appreciate the awesome contribution!

@jef jef changed the title feat(store): Add SG Location for Amazon and Newegg feat(store): add SG Location for Amazon and Newegg Jan 7, 2021
@jef jef merged commit ef926d2 into jef:main Jan 7, 2021
@wofnull wofnull deleted the SG-Amazon-Newegg branch January 8, 2021 11:49
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants