Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(galaxus): update selector #1578

Merged
merged 1 commit into from Jan 3, 2021
Merged

Conversation

wofnull
Copy link
Contributor

@wofnull wofnull commented Jan 1, 2021

Description

Galaxus changed once more the CSS marker on the site, last time on 30.12. ( opened pull request #1568 , which as not processed in the meantime and got closed by me ) and beforehand as fixxed around a week ago from knotenjoe in #1469

Testing

Script runs fine with the replaced CSS marker and pulls the correct price from the site again.

@wofnull wofnull requested a review from jef as a code owner January 1, 2021 14:36
@jef
Copy link
Owner

jef commented Jan 3, 2021

This probably needs to get changed at some point to something else, as this will probably continue to be a problem. This is most likely because this selector is generated.

Thanks for keeping this updated in the mean time!

@jef jef changed the title fix: Galaxus again changed the CSS marker for the product_details cha… fix(galaxus): update selector Jan 3, 2021
@jef jef merged commit ad5bd55 into jef:main Jan 3, 2021
@wofnull wofnull deleted the Bugfix_galaxus_01.01.2020 branch January 3, 2021 12:11
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants