Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): update out of stock detection for MediaMarkt and Saturn #1549

Merged
merged 2 commits into from Jan 3, 2021
Merged

fix(store): update out of stock detection for MediaMarkt and Saturn #1549

merged 2 commits into from Jan 3, 2021

Conversation

X123Moin
Copy link
Contributor

@X123Moin X123Moin commented Dec 29, 2020 •
edited

Fixes #1545

@X123Moin X123Moin requested a review from jef as a code owner December 29, 2020 15:46
@X123Moin X123Moin changed the title Fix out of stock detection for MediaMarkt and Saturn fix(store): update out of stock detection for MediaMarkt and Saturn Dec 29, 2020
@neatchee
Copy link
Contributor

+1

@fnk93
Copy link
Contributor

fnk93 commented Dec 29, 2020

@X123Moin Maybe don't overwrite the old tags, as MM and Saturn are changing these from time to time, but add the new tags to the list. As well as maybe add:
{ container: '#root', text: ['Dieser Artikel ist bald wieder für Sie verfügbar'] },

@gigi2006
Copy link

@X123Moin Maybe don't overwrite the old tags, as MM and Saturn are changing these from time to time, but add the new tags to the list. As well as maybe add:
{ container: '#root', text: ['Dieser Artikel ist bald wieder für Sie verfügbar'] },

yes they have already changed 2 or 3 times back and forth today. really annoying.

@selop selop mentioned this pull request Dec 30, 2020
Closed
theinternal
theinternal approved these changes Dec 30, 2020
View reviewed changes
Copy link

@theinternal theinternal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented this in my own fork - works fine/no false positives anymore, thx!

jef
jef approved these changes Jan 3, 2021
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you!

@jef jef merged commit 4f86d24 into jef:main Jan 3, 2021
erwinc1 pushed a commit to erwinc1/streetmerchant that referenced this pull request Mar 31, 2021
@X123Moin @erwinc1
fix(store): update out of stock detection for MediaMarkt and Saturn (j…
3bf4c3a 
…ef#1549)

Fixes jef#1545
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

@theinternal theinternal theinternal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives for mediamarkt.de and saturn.de
6 participants
@X123Moin @neatchee @fnk93 @gigi2006 @jef @theinternal