Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add equippr & futurex for DE region #1501

Merged
merged 5 commits into from Dec 26, 2020
Merged

feat(store): add equippr & futurex for DE region #1501

merged 5 commits into from Dec 26, 2020

Conversation

selop
Copy link
Contributor

@selop selop commented Dec 23, 2020

Description

New store for German region - equippr.de and future-x.de with support for several Nvidia RTX 3060ti, 3070 and 3080.

Testing

Edit the dotenv or .env to add the new store:

...
STORES=equippr,futurex

Sample Log:

➜  ~ pm2 logs | grep equippr
0|Merchant | [9:43:33 AM] info :: ✖ [equippr] [msi (3060ti)] ventus 2x :: OUT OF STOCK
0|Merchant | [9:43:40 AM] info :: ✖ [equippr] [zotac (3070)] twin edge oc :: OUT OF STOCK
0|Merchant | [9:43:48 AM] info :: ✖ [equippr] [zotac (3070)] twin edge :: OUT OF STOCK
0|Merchant | [9:43:55 AM] info :: ✖ [equippr] [gigabyte (3070)] eagle :: OUT OF STOCK
0|Merchant | [9:44:00 AM] info :: ✖ [equippr] [gigabyte (3070)] eagle oc :: OUT OF STOCK

@selop selop requested a review from jef as a code owner December 23, 2020 09:45
@selop selop changed the title chrome(store): added new store - equippr for DE region chore(store): added new store - equippr for DE region Dec 23, 2020
Sergej Lopatkin added 2 commits December 23, 2020 10:58
- equippr: adapted tags for maxprice, buy, out of stock
- added futurex store - co-authored by @Doerster
@selop
Copy link
Contributor Author

selop commented Dec 24, 2020

Hi,

Sorry I was not paying attention about the ongoing PR (https://github.com/jef/streetmerchant/pull/1479/files) about the equippr/futurex store. I added the futurex store in this PR and also fixed the lint errors which were caused due to encoding / formatting problems. Hope this is ok for you @Doerster and @jef.

Cheers and merry christmas.

@selop selop changed the title chore(store): added new store - equippr for DE region chore(store): added new stores - equippr & futurex for DE region Dec 24, 2020
@jef
Copy link
Owner

jef commented Dec 26, 2020

Nope, this is great! I appreciate you adding this in. Thank you very much!

@jef jef changed the title chore(store): added new stores - equippr & futurex for DE region feat(store): add equippr & futurex for DE region Dec 26, 2020
@jef jef merged commit 5b70ff1 into jef:main Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants