Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): add pcking and acompc #1470

Merged
merged 11 commits into from Dec 21, 2020
Merged

feat(store): add pcking and acompc #1470

merged 11 commits into from Dec 21, 2020

Conversation

KnotenJoe
Copy link
Contributor

Another store for Germany. I tested the code on my pc.

@KnotenJoe
Create pcking
0498590 
Another store for Germany.  I tested the code on my pc.
@KnotenJoe KnotenJoe requested a review from jef as a code owner December 19, 2020 14:36
@jef jef changed the title Create pcking feat(store): add pcking Dec 20, 2020
jef
jef previously approved these changes Dec 20, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@jef
Copy link
Owner

jef commented Dec 20, 2020

Do you mind adding to the docs?

@jef
Copy link
Owner

jef commented Dec 20, 2020

I added the docs. You're gonna need to change pcking to pcking.ts and add it to the index.ts.

@KnotenJoe
Copy link
Contributor Author

I think I did it? Sorry, I'm totally new to this and not sure. But if this checks out I also have another store for Germany that I could add.

@KnotenJoe
Copy link
Contributor Author

I think I got it now.

@KnotenJoe KnotenJoe changed the title feat(store): add pcking feat(store): add pcking and acompc Dec 21, 2020
@jef
Copy link
Owner

jef commented Dec 21, 2020

Looks great! Thank you very much. I can go in and fix the linting. This is great for a first time!

@KnotenJoe
Copy link
Contributor Author

Thanks

@jef jef enabled auto-merge (squash) December 21, 2020 17:52
@jef jef merged commit beee355 into jef:main Dec 21, 2020
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KnotenJoe @jef