Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add desktop notifications #140

Merged
merged 3 commits into from Sep 21, 2020
Merged

feat(notification): add desktop notifications #140

merged 3 commits into from Sep 21, 2020

Conversation

nacgarg
Copy link
Contributor

@nacgarg nacgarg commented Sep 20, 2020

Description

Uses node-notifier to provide cross-platform desktop notifications. Useful when sound is muted and potentially faster than other means of notification.

Testing

Tested with npm run test:notification.

New dependencies

node-notifier

@jef
Copy link
Owner

jef commented Sep 21, 2020

Thanks for the contribution! I appreciate your hard work 😄

@jef jef changed the title feat: add desktop notifications feat(notification): add desktop notifications Sep 21, 2020
@jef jef merged commit 722eaf3 into jef:main Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants