Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: newegg out-of-stock labels #134

Merged
merged 5 commits into from Sep 20, 2020
Merged

fix: newegg out-of-stock labels #134

merged 5 commits into from Sep 20, 2020

Conversation

admon84
Copy link
Contributor

@admon84 admon84 commented Sep 20, 2020 •
edited

Description

  • Changed the out of stock label for newegg because the "see similar products" banner does not always appear.
  • Also removed the bestbuy cartUrl entry on the newegg debug card link, oops!

Testing

  • Ran the script and saw the expected results for in-stock vs out-of-stock products.

New dependencies

  • N/A

@admon84 admon84 marked this pull request as ready for review September 20, 2020 21:44
@admon84 admon84 requested a review from jef as a code owner September 20, 2020 21:44
@jef jef merged commit 19c8f18 into jef:main Sep 20, 2020
@admon84 admon84 deleted the fix-newegg branch September 23, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@admon84 @jef