Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streetmerchant falsely reports AMD RX6800XT in stock for AMD Store #1329

Open
l0ppi opened this issue Dec 10, 2020 · 12 comments
Open

streetmerchant falsely reports AMD RX6800XT in stock for AMD Store #1329

l0ppi opened this issue Dec 10, 2020 · 12 comments

Comments

@l0ppi
Copy link

l0ppi commented Dec 10, 2020

Expected Behavior

The program should report "not in stock" when it's not in stock. This worked perfectly fine until the last drop on 12/08/2020.

Current Behavior

Card is reported "in stock", notification is sent and the browser opened.

Steps to Reproduce

Just added only the AMD RX6800XT and only the AMD Store. Also changed the Wait time when a card is in stock to prevent banning. Rest is left on default.

Environment

Win10 using the latest code of streetmerchant

Logs

[17:46:07] info :: ℹ selected stores: amd
[17:46:07] info :: ℹ selected series: rx6800xt
[17:46:19] info :: 🚀🚨 [amd] [amd (rx6800xt)] amd reference :: IN STOCK 🚨🚀
https://www.amd.com/en/direct-buy/5458372800/us?add-to-cart=true
[17:46:19] info :: ✔ desktop notification sent
[17:46:25] info :: ℹ [amd] [amd (rx6800xt)] amd reference :: IN STOCK, WAITING

@jef
Copy link
Owner

jef commented Dec 10, 2020

Unfortunately, I can't reproduce.

image

@l0ppi
Copy link
Author

l0ppi commented Dec 10, 2020

That is extremely strange. I deleted streetmerchant and cloned the whole thing again, this time to a different directory and then only set the series and the store. It still shows "in stock". So there must be something else that's "stuck" with the wrong status. Is there anything else that i could reset?

@thefl0yd
Copy link

can't reproduce either. you must be hitting a cache somewhere that the rest of us aren't:

streetmerchant@ start:dev C:\Users\thefloyd\streetmerchant
nodemon --config nodemon.json

[nodemon] 2.0.6
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): src*** .env
[nodemon] watching extensions: ts
[nodemon] starting ts-node --files ./src/index
STREETMERCHANT
3.2.0

[4:03:27 PM] info :: ℹ selected stores: amd
[4:03:27 PM] info :: ℹ selected series: rx6800xt
[4:03:38 PM] info :: Γ£û [amd] [amd (rx6800xt)] amd reference :: OUT OF STOCK
[4:03:49 PM] info :: Γ£û [amd] [amd (rx6800xt)] amd reference :: OUT OF STOCK

thefloyd@office-pc MINGW64 ~/streetmerchant (main)
$

@hideouspenguinboy

This comment has been minimized.

@l0ppi
Copy link
Author

l0ppi commented Dec 17, 2020

I'm still getting "In stock" results. It has never stopped since the last drop. I completely deleted streetmerchant a few times but nothing has changed.
As I have almost no knowledge about coding, i can't figure out how streetmerchant exactly gets its results. IS there any thing that might be acting as a cache?

@jef
Copy link
Owner

jef commented Dec 17, 2020

I'm still getting "In stock" results. It has never stopped since the last drop. I completely deleted streetmerchant a few times but nothing has changed.
As I have almost no knowledge about coding, i can't figure out how streetmerchant exactly gets its results. IS there any thing that might be acting as a cache?

This is for the store amd and the series rx6800xt, correct? Can you post a screenshot of what the bot took when it said it was in stock?

Thanks!


I'm still unable to reproduce myself

SHOW_ONLY_SERIES="rx6800xt"
STORES="amd"
HEADLESS="false"

image

@l0ppi
Copy link
Author

l0ppi commented Dec 17, 2020

This is for the store amd and the series rx6800xt, correct?

Exactly. I'm only interested in the AMD cards from their own store.

Can you post a screenshot of what the bot took when it said it was in stock?

Of course. Thanks for your support.

Streetmerchant

@jef
Copy link
Owner

jef commented Dec 18, 2020

It looks like you're running an old version of streetmerchant. Do you mind doing a git pull origin main and running npm install?

@l0ppi
Copy link
Author

l0ppi commented Dec 18, 2020

Oh, there's the 3.3.0. Didn't notice that.
I updated the files, but the results remains the same a you can see :/

Streetmerchant 2

@jef
Copy link
Owner

jef commented Dec 21, 2020

Sorry, it's hard to tell what's going on. Perhaps we're getting redirects and I don't like that. One solution is ensuring we don't get redirected. Another solution is that we check for selectors that give us the name of the product to ensure what we're looking for.

Either way, this is probably intermittent.

@fabitrox
Copy link

I just had the same problem: I tried to run the bot on AMD-de from switzerland. Since the store always redirects to the swiss store, the alert popped up and showed "in stock", but wasn't available. So that might be the same problem.

@nextinfinity
Copy link

I have a similar issue - getting a false positive on RX6900XT. At least in this case, it is clearly a redirect from the product page to the general store page. This is the screenshot that was captured:

success-1621447862437

...while this is the console output:

image

In my browser, I land on https://www.amd.com/en/direct-buy/us.

@jef jef changed the title Stereetmerchant falsely reports AMD RX6800XT in stock for AMD Store streetmerchant falsely reports AMD RX6800XT in stock for AMD Store May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants