Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discord): dynamic currency symbol #1328

Merged
merged 8 commits into from Dec 12, 2020
Merged

feat(discord): dynamic currency symbol #1328

merged 8 commits into from Dec 12, 2020

Conversation

YiIdirim
Copy link
Contributor

@YiIdirim YiIdirim commented Dec 10, 2020 •
edited

Description

  • Fixes the default currency used for Discord notifications ($) to be store specific
  • Added currency as a requirement for each store to define the correct symbol to be shown
  • Refactored every store to show the name at the top rather than the bottom

Testing

  1. Set a discord notification (e.g. webhook)
  2. Check for an in stock item at any store of your choosing
  3. Verify the correct currency symbol is shown in the discord notification

Fixes issue: #1318

@YiIdirim YiIdirim requested a review from jef as a code owner December 10, 2020 16:48
@YiIdirim YiIdirim mentioned this pull request Dec 10, 2020
Closed
@jef
Copy link
Owner

jef commented Dec 10, 2020

Hi @Sohaiiil! Thanks for contributing! Looks great overall, but the linting does unfortunately matter. If you are able to put back where name was and keep currency, this looks great to me!

@YiIdirim
Copy link
Contributor Author

@jef requested changes have been made

jef
jef approved these changes Dec 12, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for all the hard work on this one. I appreciate your help.

@jef jef changed the title fix(discord): currency symbol in notifications feat(discord): dynamic currency symbol Dec 12, 2020
@jef jef merged commit cccfde2 into jef:main Dec 12, 2020
@YiIdirim YiIdirim deleted the currency-update branch December 12, 2020 15:43
@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YiIdirim @jef