feat(notification): add sound player executable option

[warmar]

Description

Allows the default sound player to be overridden. I was having trouble on Ubuntu with the default player which sound-player chose.

Testing

Ran locally

New dependencies

None

[jef]

Cool! Looks good to me. Quick question though, what sound player do you have? It seems like the supported libraries are sufficient, but maybe that's not the case.

[warmar]

Cool! Looks good to me. Quick question though, what sound player do you have? It seems like the supported libraries are sufficient, but maybe that's not the case.

By default, play-sound detects aplay, which is indeed installed on my system. When it plays a sound, however, all I hear is static, buzzing, and popping. Even when I run aplay from the command line, this happens. I have not yet been able to identify the problem.

For now, I just switched to using vlc and that has been working fine.

EDIT: Looks like installing sox (play) also resolved the issue. I can still see this option being useful on systems with several of the default supported players installed.

[jef]

Looks like installing sox (play) also resolved the issue. I can still see this option being useful on systems with several of the default supported players installed.

I also use sox on my system, so I never ran into that one before! Thanks for the clarification.

I agree, the default list is somewhat limiting and it also causes the behavior on Windows to post INFO: Could not find files for the given pattern(s).

See (somewhat) related: #1035

This will be good to keep in mind when we start to move to the new config.

Thanks for the great contribution!