Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add table sorting #1258

Merged
merged 11 commits into from Dec 8, 2020
Merged

feat(docs): add table sorting #1258

merged 11 commits into from Dec 8, 2020

Conversation

zethussuen
Copy link
Contributor

Description

Testing

New dependencies

@zethussuen zethussuen requested a review from jef as a code owner December 8, 2020 17:29
@jef jef marked this pull request as draft December 8, 2020 19:43
@jef jef changed the title [WIP] Add table sorting example for STORES list reference docs: add table sorting example for STORES list reference Dec 8, 2020
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'm gonna pull this down and see what this looks like!

docs/reference/filter.md Outdated Show resolved Hide resolved
@jef
Copy link
Owner

jef commented Dec 8, 2020

Awesome! I totally missed this.

https://squidfunk.github.io/mkdocs-material/reference/data-tables/#sortable-tables

This is pretty sweet!

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, to fix the build, can you add

,
  "include": ["src/**/*"]

to tsconfig.json

docs/reference/filter.md Outdated Show resolved Hide resolved
docs/reference/filter.md Outdated Show resolved Hide resolved
docs/reference/filter.md Outdated Show resolved Hide resolved
@jef jef changed the title docs: add table sorting example for STORES list reference feat(docs): add table sorting example for STORES list reference Dec 8, 2020
@jef jef changed the title feat(docs): add table sorting example for STORES list reference feat(docs): add table sorting Dec 8, 2020
zethussuen and others added 3 commits December 8, 2020 14:56
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
@jef
Copy link
Owner

jef commented Dec 8, 2020

You can ignore my comment on the tsconfig.json. I pushed that up to main. Thanks!

@zethussuen
Copy link
Contributor Author

zethussuen commented Dec 8, 2020

@jef any guidance on how you want to handle the js file that's included from the repo example? fails build-and-lint PR checks as it is not proper ts.

edit: just realized the project is using xo as its linter and not tslint. Will add to the excludes folder and push up

@zethussuen zethussuen marked this pull request as ready for review December 8, 2020 21:30
@zethussuen
Copy link
Contributor Author

@jef Assuming no new stores are added, this should be good for review as of 4:40pm Eastern. There were a few that were ingested from rebases: walmart-ca, saturn, and toysrus. I also added an xo-linter rule that ignores the docs/javascripts folder. Up to you how you want to handle though!

@R3PTIL3
Copy link

R3PTIL3 commented Dec 8, 2020

Otto and Expert = DE 👍🏼

@jef
Copy link
Owner

jef commented Dec 8, 2020

I also added an xo-linter rule that ignores the docs/javascripts folder.

Good idea!

Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much :)

@jef jef merged commit 5955d10 into jef:main Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants