New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add table sorting #1258
Conversation
STORES
list reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'm gonna pull this down and see what this looks like!
Awesome! I totally missed this. https://squidfunk.github.io/mkdocs-material/reference/data-tables/#sortable-tables This is pretty sweet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, to fix the build, can you add
,
"include": ["src/**/*"]
to tsconfig.json
STORES
list referenceSTORES
list reference
STORES
list referenceCo-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
Co-authored-by: Jef LeCompte <jeffreylec@gmail.com>
You can ignore my comment on the |
@jef any guidance on how you want to handle the js file that's included from the repo example? fails build-and-lint PR checks as it is not proper ts. edit: just realized the project is using xo as its linter and not tslint. Will add to the excludes folder and push up |
@jef Assuming no new stores are added, this should be good for review as of 4:40pm Eastern. There were a few that were ingested from rebases: |
Otto and Expert = DE 👍🏼 |
Good idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you very much :)
Description
Testing
New dependencies