Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): italian store checks #1212

Merged
merged 1 commit into from Dec 8, 2020
Merged

fix(store): italian store checks #1212

merged 1 commit into from Dec 8, 2020

Conversation

lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Dec 6, 2020 •
edited

Description

Fix some issues on some Italian store.
In particular:

  • ePrice store sometimes products where show wrongly in stock
  • Amazon-it do not correctly see the caption page
  • Uniero return a blank page after too many requests

Test

I used the trick on issue #1194 to always save a screenshot. Maybe it can be useful to have a configuration option to do that.

@lucarin91 lucarin91 requested a review from jef as a code owner December 6, 2020 10:02
@lucarin91 lucarin91 changed the title fix(store): bug in ePrice store fix(store): update the italian store checks Dec 7, 2020
@jef
Copy link
Owner

jef commented Dec 8, 2020

I used the trick on issue #1194 to always save a screenshot. Maybe it can be useful to have a configuration option to do that.

Good point. Maybe I can add this in. Except it would start taking up a lot of disk space quickly, so perhaps rolling images.

jef
jef approved these changes Dec 8, 2020
View reviewed changes
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and fixes!

@jef jef changed the title fix(store): update the italian store checks fix(store): italian store checks Dec 8, 2020
@jef jef merged commit e3eb386 into jef:main Dec 8, 2020
@razor992fg
Copy link

@lucarin91 hello luca, can you add mediaworld.it please??? i'm italian :)

@github-actions github-actions bot mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucarin91 @jef @razor992fg