Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Price in Discord Notification #1188

Closed
FawnPat opened this issue Dec 5, 2020 · 4 comments · Fixed by #1209
Closed

Show Price in Discord Notification #1188

FawnPat opened this issue Dec 5, 2020 · 4 comments · Fixed by #1209
Assignees
@jef
Labels
type: feature

Comments

@FawnPat
Copy link

FawnPat commented Dec 5, 2020

Description

I would like to be able to display the price of the product in the discord notification messages I send.

From what I can tell the bot does not currently capture the price of the product into a variable.

Possible solution

My suggestion would be to update the "link" variable in the Discord notification template to have a "price" property.
@jef
Copy link
Owner

jef commented Dec 5, 2020

Good idea!

jef added a commit that referenced this issue Dec 5, 2020
@jef
feat(notification): add price to links
7883a90 
Resolves #1188
@jef jef mentioned this issue Dec 5, 2020
Merged
@jef
Copy link
Owner

jef commented Dec 5, 2020

Let me know what you think, I'll be pulling it in shortly.

@jef jef closed this as completed in #1209 Dec 6, 2020
jef added a commit that referenced this issue Dec 6, 2020
@jef
feat(notification): add price to links (#1209)
15ec12b 
fix(store): label selection ordering and pricing
fix(nvidia): deprecation notice removed outside of usa
fix(amazon): maxPrice selector

Resolves #1188
Resolves #673
Resolves #1187
@scurker scurker mentioned this issue Dec 8, 2020
Closed
@FawnPat
Copy link
Author

FawnPat commented Dec 16, 2020

Let me know what you think, I'll be pulling it in shortly.

Thanks for adding this in. It's quite helpful to be able to see the price before clicking on a product link.

I may be wrong, but did you set up the code to only display the price one could be captured?

@jef
Copy link
Owner

jef commented Dec 17, 2020

I may be wrong, but did you set up the code to only display the price one could be captured?

Yeah! That's correct. If you don't see a price, it means we don't have a container for it and the code needs to get updated.

@github-actions github-actions bot mentioned this issue Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jef jef

Labels
type: feature
Projects
None yet
Milestone
No milestone
2 participants
@jef @FawnPat