Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otto wrong product #1163

Closed
TDCroPower opened this issue Dec 4, 2020 · 7 comments · Fixed by #1183
Closed

Otto wrong product #1163

TDCroPower opened this issue Dec 4, 2020 · 7 comments · Fixed by #1183
Assignees

Comments

@TDCroPower
Copy link

Description

the wrong product is being tested at Otto.
You get the remote control instead of the consoles reported.

otto_falsealert

Possible solution

change Product ID ?

@TDCroPower
Copy link
Author

oh ok, if I follow the links manually, Otto redirects me to the remote control.

German:
"Deinen gewünschten Artikel können wir leider nicht mehr liefern.
Hier findest du einen Artikel, der dir auch gefallen könnte."

English:
"Unfortunately, we can no longer deliver your desired article.
Here you will find an article that you might like."

otto_umleitung

Is there a way to prevent this?

@gigi2006
Copy link

gigi2006 commented Dec 4, 2020

its the same problem #1132

@TDCroPower
Copy link
Author

Yes can anyone link the 2 bug reports?

@joerg-knitter
Copy link

joerg-knitter commented Dec 5, 2020

I think the link might be correct, because with the 3rd order wave on november 19th, I got a PS5 into my basket, but one day later, the order got cancelled. But in my order history, there is a link to the product page, and this is the same as in the otto.ts file.

On the other hand, I definately got no alarm by the script when I let it run yesterday with the default settings - which is kind of strange when they really sold a few consoles yesterday as reported in the media.
However, there are rumours out there that the orders were taken by phone and that they had only a small amount, so maybe they really did not sell anything online.

@jef
Copy link
Owner

jef commented Dec 5, 2020

I think the link might be correct

I think you're right, because https://www.otto.de/p/playstation-5-1136008456/#variationId=1136008459 forwards to https://www.otto.de/p/playstation-5-medienfernbedienung-1170617135/#variationId=1170617136.

As of now, there isn't any way around this, except maybe IN_STOCK_WAIT_TIME, but that's not even a good solution.

Like @gigi2006 said, take a look at #1132 (comment). I believe that'll be the solution. I can see if I can do something about that.

I'll need help from contributors though to get the proper text. But I can code the implementation.

Scratch that, we can use the inStock selector.

@jef
Copy link
Owner

jef commented Dec 5, 2020

I think adding something like this would be good

inStock: [
	{
		container:
			'button.prd_ordering__button.p_btn150--1st.js_product_addToBasket',
		text: ['In den Warenkorb']
+	},
+	{
+		container: '.js_shortInfo__variationName.prd_shortInfo__variationName',
+		text: ['konsole']
+	}
],

But this would be site wide, which wouldn't be great.

@jef
Copy link
Owner

jef commented Dec 5, 2020

Take a look at that PR and let me know if that looks good (in terms of what the text should say).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants