feat(scraping): change lookup impl, add randomize sleep #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid bot detection better
jef
requested changes
Sep 20, 2020
jef
approved these changes
Sep 20, 2020
jef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the async queue into multiple indepentend timeouts.
It also adds a randomized sleep which might help avoid newegg's bot detection even better (it still CAPTCHA's me at times, so we probably need more on that front).
It also doesn't suffer from the (theoretical) bug of the async queue draining
Testing
Ran with my usual configuration and observed it correctly creating timeouts
New dependencies