Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add telegram #71

Merged
merged 5 commits into from Sep 19, 2020
Merged

feat(notification): add telegram #71

merged 5 commits into from Sep 19, 2020

Conversation

Doridian
Copy link
Collaborator

@Doridian Doridian commented Sep 19, 2020

Description

Closes #72

Add Telegram as a notification channel.

Also adds a .editorconfig which makes most editors use the correct line endings and indentations

Testing

Set a valid TELEGRAM_* variables in .env, set NOTIFICATION_TEST=true, saw notification on Telegram

New dependencies

messaging-api-telegram nodejs package added to package.json

@Doridian Doridian requested a review from jef as a code owner September 19, 2020 17:00
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Let me know what you think. I like the .editorconfig and the catchpa labels!

src/store/lookup.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/store/lookup.ts Show resolved Hide resolved
src/store/model/amazon.ts Show resolved Hide resolved
@jef jef self-assigned this Sep 19, 2020
@Doridian
Copy link
Collaborator Author

Addressed comments.

@Doridian Doridian requested a review from jef September 19, 2020 19:58
@jef jef changed the title feat(notifications): Add Telegram notification ability feat(notification): add telegram Sep 19, 2020
@jef jef merged commit 393d5f6 into jef:main Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Split out CAPTCHA labels out of oosLabels
2 participants