feat: webpage toggle, sound notification, fix evga links #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2020 22:20
Add sound notification. Add toggle for opening web browser.
|
I heavily suggest that the notification sound is https://www.youtube.com/watch?v=gjVmeKWOsEU I can provide .wav |
jef
requested changes
Sep 19, 2020
src/play-sound.d.ts
Outdated
| @@ -0,0 +1 @@ | |||
| declare module 'play-sound'; | |||
|
Otherwise, great contribution. Thank you! |
jef
approved these changes
Sep 19, 2020
jef
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add sound notification ding
feat: toggle for opening webpage (good for if you're trying to run this on a VM or server)
fix: evga; add individual cards, rather than the whole search page for the 3080
New dependencies
"play-sound": "^1.1.3",