-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): add timestamp #48
Conversation
A quick google suggests you can just change the Logger itself instead. It shouldn't be the responsibility of |
Good point, moved it to logger. |
previous version did not correctly update time. now fixed
@wuruochong I tried making a similar change with Logger native Either way, I like this format having the timestamp consistently on the front of the line, like you have it in your latest commit. |
I too was doing this originally, but decided just to leave it out without hackin' up the timestamp type. I think at this point we definitely need timestamps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Looks great 🚀 😄
Description
Added time to end of each line. Helps identify if program hangs.
Testing
Ran program with both out of stock and fake in stock messages. Verified that time is at the end of each line.