Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: newegg out-of-stock #124

Merged
merged 4 commits into from Sep 20, 2020
Merged

fix: newegg out-of-stock #124

merged 4 commits into from Sep 20, 2020

Conversation

admon84
Copy link
Contributor

@admon84 admon84 commented Sep 20, 2020

Description

Testing

  • Tested the newegg scraping for in-stock and out-of-stock cards and saw expected results

New dependencies

  • N/A

@admon84 admon84 requested a review from jef as a code owner September 20, 2020 20:07
Doridian
Doridian previously approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@Doridian Doridian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you moved the XC3 ultra? If no, just move it back to keep the changeset smaller.

@Doridian Doridian mentioned this pull request Sep 20, 2020
Closed
@admon84
Copy link
Contributor Author

admon84 commented Sep 20, 2020

Moved it for testing and forgot to put it back, just constantly trying to disrupt the nicely organized code

@jef jef mentioned this pull request Sep 20, 2020
Merged
@jef jef merged commit 770a13a into jef:main Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Doridian Doridian Doridian approved these changes

@jef jef jef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@admon84 @Doridian @jef