Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] combined with Manim voice:slides1-voice1, slides2-voice2, slides3-voice3 #258

Open
flmdaybreak opened this issue Aug 26, 2023 · 1 comment
Labels
enhancement New feature or request html-convert Related to converting to HTML slides lib Related to the library (a.k.a. module) present Related to the main "present" feature python Pull requests that update Python code
Milestone

Comments

@flmdaybreak
Copy link

Description

I really appreciate the work you've done on this project. It's fantastic! I have a feature request to make the experience even better.

The effect I hope to achieve by integrating Manim voice is as follows: slides1-voice1, slides2-voice2, slides3-voice3, and so on. Within the current slides page, explanatory voice-over tailored for the current slide will be played. It's possible to switch slides even if the voice-over or animation hasn't finished playing. The corresponding voice-over and animation start simultaneously, but they can end at different times.

Thank you for considering this enhancement!

Screenshots

No response

Additional information

No response

@flmdaybreak flmdaybreak added the enhancement New feature or request label Aug 26, 2023
@flmdaybreak flmdaybreak changed the title [FEATURE] <description> [FEATURE] combined with Manim voice:slides1-voice1, slides2-voice2, slides3-voice3 Aug 26, 2023
@jeertmans
Copy link
Owner

Thanks for the suggestion! I think there are two mandatory steps for that:

  1. Add some audio output in the new player (v5), should be easy.
  2. Enable audio in HTML-produced file (currently disabled), but warning that you cannot have audio in the first slide (this is because most web browsers does not allow HTML to autoplay audio without user input, mostly to avoid audio popups).

And three optional ones:
3. Document the support for basic audio.
4. Document the support for ManimVoiceOver by explicitly showing an example (maybe the main tutorial)
5. Maybe optional install manim_voiceover using extras.

I will not have time for that in the upcoming days, but this will hopefully be implemented sooner or later :-)

If anyone wants to try implementing this, feel free to fill a PR!

@jeertmans jeertmans added html-convert Related to converting to HTML slides present Related to the main "present" feature lib Related to the library (a.k.a. module) python Pull requests that update Python code labels Aug 26, 2023
@jeertmans jeertmans added this to the v6 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html-convert Related to converting to HTML slides lib Related to the library (a.k.a. module) present Related to the main "present" feature python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants