Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

cordova-android@7.0.0 incompatibility #599

Closed
peterpeterparker opened this issue Dec 7, 2017 · 70 comments
Closed

cordova-android@7.0.0 incompatibility #599

peterpeterparker opened this issue Dec 7, 2017 · 70 comments

Comments

@peterpeterparker
Copy link
Collaborator

peterpeterparker commented Dec 7, 2017

Hi,

It looks like cordova-plugin-facebook4 isn't compatible with cordova-android 7.0.0

I'm guessing that the incompatibility source is the following element in plugin.xml

  <config-file target="AndroidManifest.xml" parent="application">
        <meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/fb_app_id"/>
        <meta-data android:name="com.facebook.sdk.ApplicationName" android:value="@string/fb_app_name" />
        <activity android:name="com.facebook.FacebookActivity"
          android:configChanges="keyboard|keyboardHidden|screenLayout|screenSize|orientation"
          android:label="@string/fb_app_name" />
    </config-file>

Regarding what was indicated in https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html

Steps to reproduce:

 ionic start cordova-7
 ionic cordova platform add cordova-android@7.0.0
 ionic cordova plugin add cordova-plugin-facebook4 --save --variable APP_ID="123456789" --variable APP_NAME="myApplication"
 ionic cordova build android

Thx in advance for any help

Stacktrace:

BUILD FAILED in 12s
25 actionable tasks: 4 executed, 21 up-to-date
Error: /Users/me/Documents/projects/test/cordova-7/platforms/android/gradlew: Command failed with exit code 1 Error output:
/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:112: AAPT: error: resource string/fb_app_id (aka io.ionic.starter:string/fb_app_id) not found.

/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:115: AAPT: error: resource string/fb_app_name (aka io.ionic.starter:string/fb_app_name) not found.

/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:119: AAPT: error: resource string/fb_app_name (aka io.ionic.starter:string/fb_app_name) not found.

/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:112: error: resource string/fb_app_id (aka io.ionic.starter:string/fb_app_id) not found.
/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:115: error: resource string/fb_app_name (aka io.ionic.starter:string/fb_app_name) not found.
/Users/me/Documents/projects/test/cordova-7/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:119: error: resource string/fb_app_name (aka io.ionic.starter:string/fb_app_name) not found.
error: failed processing manifest.

Failed to execute aapt
com.android.ide.common.process.ProcessException: Failed to execute aapt
at com.android.builder.core.AndroidBuilder.processResources(AndroidBuilder.java:796)
at com.android.build.gradle.tasks.ProcessAndroidResources.invokeAaptForSplit(ProcessAndroidResources.java:551)
at com.android.build.gradle.tasks.ProcessAndroidResources.doFullTaskAction(ProcessAndroidResources.java:285)
at com.android.build.gradle.internal.tasks.IncrementalTask.taskAction(IncrementalTask.java:109)
at sun.reflect.GeneratedMethodAccessor313.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$IncrementalTaskAction.doExecute(DefaultTaskClassInfoStore.java:173)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:121)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:122)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:111)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:92)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:70)
at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:63)
at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:52)
at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:248)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:241)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:230)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:124)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:80)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:105)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:99)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:625)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:580)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:99)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: com.android.tools.aapt2.Aapt2Exception: AAPT2 error: check logs for details
at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:503)
at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:482)
at com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:79)
at com.android.builder.core.AndroidBuilder.processResources(AndroidBuilder.java:794)
... 47 more
Caused by: java.util.concurrent.ExecutionException: com.android.tools.aapt2.Aapt2Exception: AAPT2 error: check logs for details
at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:503)
at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:462)
at com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:79)
at com.android.builder.internal.aapt.v2.QueueableAapt2.lambda$makeValidatedPackage$1(QueueableAapt2.java:179)
Caused by: com.android.tools.aapt2.Aapt2Exception: AAPT2 error: check logs for details
at com.android.builder.png.Aap
[ERROR] An error occurred while running cordova build android (exit code 1).

@peterpeterparker peterpeterparker changed the title cordova-android 7.0.0 incompatibility cordova-android@7.0.0 incompatibility Dec 7, 2017
@amritk
Copy link

amritk commented Dec 9, 2017

Having the exact same issue in a non ionic cordova app

@amritk
Copy link

amritk commented Dec 9, 2017

Hey @peterpeterparker I opened a pull request for it. In the meantime you could try

cordova plugin add https://github.com/amritk/cordova-plugin-facebook4 --save --variable APP_ID="" --variable APP_NAME=""

and let me know how it works.

@peterpeterparker
Copy link
Collaborator Author

peterpeterparker commented Dec 9, 2017

@amritk sweet, thx for taking the time to fix it! It looks good to me too, with your PR I was able to build a project with cordova-android@7.0.0 and cordova-plugin-facebook4 👍

note: I didn't tested the results but I checked the platform to see if fb_app_id and fb_app_name were correctly set. both android.json and facebookconnect.xml contains the variables I specified, therefore I think that it's ok

@nezirz
Copy link

nezirz commented Dec 30, 2017

Add string resources into (I am using linux ubuntu this is my ionic project path) file : /home/user/js/fb4/platforms/android/app/src/main/res/values/strings.xml

<string name="fb_app_id">59523234234</string>
<string name="fb_app_name">hajmo.ba</string>

and my project now works!

@welkensoyo
Copy link

I can't get the app to see the facebook API after the fix... any ideas?

@ChrisHSandN
Copy link

As a temporary fix which doesn't need manual editing of any platform specific files:

Add to config.xml

<platform name="android">
    <config-file parent="/resources" target="./res/values/strings.xml">
        <string name="fb_app_id">1234</string>
        <string name="fb_app_name">foobar</string>
    </config-file>
    ...

@justinwaite
Copy link

Also seeing this problem with Cordova version: 8.0.0, "cordova-android": "7.0.0",
and "cordova-plugin-facebook4": "1.9.1".

@ChrisHSandN Thank you for your solution! This worked for me.

@peterpeterparker
Copy link
Collaborator Author

cool @ChrisHSandN your workaround just works fine

@velrino
Copy link

velrino commented Jan 28, 2018

@ChrisHSandN thanks!

@hassanamin994
Copy link

@ChrisHSandN Day saver, Thanks!

@jjrchrds
Copy link

jjrchrds commented Feb 1, 2018

@ChrisHSandN I see the following when I add that to my config.xml

Error: Unable to graft xml at selector "/resources" from ... during config install

@mhadaily
Copy link

mhadaily commented Feb 1, 2018

@ChrisHSandN thanks man!

@csotomon
Copy link

@ChrisHSandN thank you, is working

@soumak77
Copy link

@jjrchrds I was having the same issue. I fixed it by changing the parent attribute to parent="/*"

@rolinger
Copy link

@amritk @jdeanwaite - I too am running Cordova@8.0, cordova-android@7.0. The native/base facebook4 plugin installs but errors out during compile. I used the version @amritk posted just above cordova plugin add https://github.com/amritk/cordova-plugin-facebook4 --save --variable APP_ID="" --variable APP_NAME="" and it installed and compiled.

I am migrating my app which is currently on older revs of everything (ionic v1, Cordova 7, cordova-android: 6.2.3) so today I was just rebuilding my environment to be the 42 different plugins my app uses all installed, compiled and stable. This facebook4 plugin was the last one and at the moment it looks like its working.

Now I get to spend the next few weeks porting all my code from Ionic v1 format into the newer v3 format - and then probably rewriting tons of extra stuff to take advantage of all the new techniques and features. Ugh...not looking forward to this!

@HugoHeneault
Copy link

@rolinger If you're only starting to port it and you can wait, you'd better wait for v4 to go out as it might change a lot of things you just changed. v3 doesn't get any support anymore :(

@tennist
Copy link

tennist commented Mar 7, 2018

In addition to @ChrisHSandN solution above, the plugin.xml file for this plugin needs to be updated as well to work with the latest libraries. Line 46 needs to be updated to:

<preference name="android-minSdkVersion" value="17" />

@mohamedsharaf
Copy link

@HugoHeneault where is v4 branch

@HugoHeneault
Copy link

HugoHeneault commented Mar 7, 2018

We're talking about ionic v4 branche, it's the "core" branch ;)
But it's not even alpha yet, I think

@marcocanino
Copy link

Remove platform 7.0.0 and install 6.4.0

ionic cordova platform rm android

ionic cordova platform add android@6.4.0

@phingers
Copy link

@marcocanino - worked like a charm for my ionic app, that seemed the easiest out of all the listed ideas. Thank you.

sebastianovide added a commit to sebastianovide/cordova-plugin-facebook4 that referenced this issue Mar 22, 2018
@quedicesebas
Copy link

no way with android 7.0.0 or 7.1.0?

@fawrn
Copy link

fawrn commented Apr 5, 2018

this is the currently working

npm isntall -g cordova@7.1
ionic cordova platform add android@6.4

@mbunge
Copy link

mbunge commented Sep 19, 2018

Hey there,

I added the following config into config.xml:widget (not ):

mode="add" was necessary for me.

    <edit-config file="res/values/strings.xml" mode="add" target="/resources">
        <string name="fb_app_id">1234</string>
        <string name="fb_app_name">foobar</string>
    </edit-config>

My environment:

Ionic:

   ionic (Ionic CLI)  : 4.1.2
   Ionic Framework    : ionic-angular 3.9.2
   @ionic/app-scripts : 3.2.0

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-webview 2.1.3, (and 10 other plugins)

System:

   Android SDK Tools : 26.1.1
   ios-deploy        : 1.9.2
   NodeJS            : v10.7.0
   npm               : 6.4.1
   OS                : macOS High Sierra
   Xcode             : Xcode 9.3.1 Build version 9E501

Also keep following in mind: https://github.com/jeduan/cordova-plugin-facebook4/blob/master/docs/android/README.md#older-cordova-cli

@lucasnuneslbn
Copy link

Folks! I love you all! It worked for me:

In plugin.xml:
<preference name="android-minSdkVersion" value="17" />
In my config.xml:

<preference name="phonegap-version" value="cli-8.0.0" />
<preference name="android-minSdkVersion" value="17" />
    <preference name="android-targetSdkVersion" value="25" />
 <platform name="android">
		<!-- bug facebook4 plugin -->
		<config-file parent="/resources" target="./res/values/strings.xml">
			<string name="fb_app_id">161212018147589</string>
			<string name="fb_app_name">Teste</string>
		</config-file>
               ....
 </platform>

 <plugin name="cordova-plugin-facebook4" source="npm" spec="3.0.0">
        <variable name="APP_ID" value="161212018147589" />
        <variable name="APP_NAME" value="Teste" />	
		<variable name="FACEBOOK_ANDROID_SDK_VERSION" value="4.35.0" />
    </plugin>
	<engine name="android" spec="^7.0.0" />

Thanks a lot,
You are beasts!

@sdklab007
Copy link

@ChrisHSandN Solutions works like a charm for Android 7.0.0:)

@globules-io
Copy link

Just here to report that Cordova 7.x + Android 7.x is not working with any of the work arounds found in this ticket. See #718

@briancalma
Copy link

@ChrisHSandN
Dude! your solution worked like a charm! Thank you for saving me!

@vlafranca
Copy link

vlafranca commented Oct 30, 2018

@globules-io I just found a solution that work after struggling for days.
The fact is :

<config-file parent="/resources" target="./res/values/strings.xml">  
           <string name="fb_app_id">123456789</string>  
           <string name="fb_app_name">MYAPP</string>  
     </config-file>

works on linux but on windows platform you have to remove the './' at the beginning of target lie this :

<config-file parent="/resources" target="res/values/strings.xml">
           <string name="fb_app_id">123456789</string>
           <string name="fb_app_name">MYAPP</string>
       </config-file>

after removing and adding your platform again you may have an other scarry error while building, you can solve by updating your project.properties with this :

cordova.system.library.8=com.google.gms:google-services:3.2.0

instead of this :
cordova.system.library.8=com.google.gms:google-services:+

I tryed to automize that update by putting that line under platform="android" : <framework src="com.google.gms:google-services:3.2.0" /> on the config.xml but it does not work (means when adding the platform again I have to manually edit the project.properties file)

@marvinug
Copy link

marvinug commented Nov 9, 2018

@ChrisHSandN Thank you for your solution! This worked for me.

@spinninghamster
Copy link

spinninghamster commented Nov 13, 2018

I am on Android 7.0.0 and I am experiencing the same problem but I keep getting this error:

/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:111: AAPT: error: resource string/fb_app_id (aka com.domain.app:string/fb_app_id) not found.
    
/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:114: AAPT: error: resource string/fb_app_name (aka com.domain.app:string/fb_app_name) not found.
    
/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:118: AAPT: error: resource string/fb_app_name (aka com.domain.app:string/fb_app_name) not found.
    
/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:111: error: resource string/fb_app_id (aka com.domain.app:string/fb_app_id) not found.
/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:114: error: resource string/fb_app_name (aka com.domain.app:string/fb_app_name) not found.
/Users/app/platforms/android/app/build/intermediates/manifests/full/debug/AndroidManifest.xml:118: error: resource string/fb_app_name (aka com.domain.app:string/fb_app_name) not found.
error: failed processing manifest.

I tried both:

<config-file parent="/resources" target="./res/values/strings.xml">  
  <string name="fb_app_id">123456789</string>  
  <string name="fb_app_name">MYAPP</string>  
</config-file>

and:

<config-file parent="/resources" target="app/src/main/res/values/strings.xml">  
  <string name="fb_app_id">123456789</string>  
  <string name="fb_app_name">MYAPP</string>  
</config-file>

and it's still not working. I even tried adding mode="merge" or mode="add". Still the same error message. Anyone have a solution?

@spinninghamster
Copy link

UPDATE:

This version by @amritk fixed it for me:
cordova plugin add https://github.com/amritk/cordova-plugin-facebook4 --save --variable APP_ID="" --variable APP_NAME=""

@globules-io
Copy link

@spinninghamster only thing that worked for me on Windows with Android 7 is add strings by hand in strings.xml...

@hiepxanh
Copy link

finally, I can find what exactly problem when I change my code in config but it still not update. turn out that it add new to platforms/android/android.json everytime I change facebook App Name and App Id:
image

I remove not valid key in there and it start building

@david95thinkcode
Copy link

@ChrisHSandN solution works perfectly 👍

@nieok
Copy link

nieok commented Nov 20, 2018

Has anyone found a solution or work around for PGB cordova android 7.0.0?

@davidluthiers
Copy link

davidluthiers commented Nov 20, 2018

Has anyone found a solution or work around for PGB cordova android 7.0.0?

Yes :)
I used this repository:
<plugin spec="https://github.com/akhatri/cordova-plugin-facebook4.git"> <param name="APP_ID" value="XX" /> <param name="APP_NAME" value="X" /> </plugin>

@nieok
Copy link

nieok commented Nov 20, 2018

@davidluthiers appreciated! saved my life! ive been trying to solve this for 2 days.

@brentverhenne
Copy link

I still seem to have an error with the solutions provided above. I am using the latest version of this plugin with cordova version 8.0.0 and Android 7.1.4.

java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Unable to merge dex

Any ideas what is the cause? Downgrading my android is not an option as i have other plugins requiring this.

@pablokintopp
Copy link

For those who still are having problems and happens to have the phonegap-plugin-barcodescanner plugin installed on the project. I suggest you try out to use the cordova-plugin-facebook4@1.7.4 version.

Check out this stackoverflow answer for a step-by-step solution.

It worked for me. Apparently, those plugins have incompatibility issues....

@peterpeterparker
Copy link
Collaborator Author

peterpeterparker commented Dec 15, 2018

I just released v4.0.0 which solves this issue without the need of any workaround anymore. Also note that the improvement in the tooling is backwards compatible with cordova-android < v7 too.

BREAKING CHANGE: Note that if you would have add the workaround in your config.xml you would need to remove it from your configuration when you upgrade to v4.0.0 (see CHANGELOG)

Thx @adipascu for the PR, you deserve a cookie 👍

@codinronan
Copy link

I just wanted to add to this thread for anyone reading it - if you are using Cordova >= 7 and cordova-android >= 7 and you still see these warnings, that is to be expected! You should see it printed out 3 times ONLY - any more than that and you have a genuine issue. This is because for backwards compatibility, the plugin attempts to update BOTH the Cordova <= 6 and Cordova 7+ file paths, and if you are on later Cordova, naturally you don't have the <= 6 paths, so it emits a warning. This is normal.

@jdogresorg
Copy link

@ChrisHSandN Your solution got my builds working again. Kudos sir 👍

@alirazashaw
Copy link

finally, I can find what exactly problem when I change my code in config but it still not update. turn out that it add new to platforms/android/android.json everytime I change facebook App Name and App Id:
image

I remove not valid key in there and it start building

Saved my day <3

@sahyun1
Copy link

sahyun1 commented Jun 9, 2019

I also notice if you have cordova-universal-link plugin, building won't work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.