Support for the missing platforms in the NuGet package

[samuel-lucas6]

People have expressed interest in support for Android and iOS among the .NET bindings:

samuel-lucas6/Geralt#7
ektrah/nsec#73
ektrah/libsodium-core#101
ektrah/libsodium-core#80
ektrah/libsodium-core#89
#1122
#1332

There's also interest in support for Windows ARM64:

#1360
#1219
#1104

Would it be possible to add the missing platforms to the NuGet package? How difficult is this/what assistance is required?

I unfortunately haven't done anything with these platforms. If anyone has/is able to help, these users/us maintainers would be extremely grateful for your help.

[jedisct1]

ARM64 support is easy to add, but I don't know how to test it 🤷

Libraries for all Apple platforms are built with the dist-build/apple-xcframework.sh script, but I don't know what changes are required to use an xcframework in a NuGet package.

[MartyIX]

Libraries for all Apple platforms are built with the dist-build/apple-xcframework.sh script, but I don't know what changes are required to use an xcframework in a NuGet package.

@rolfbjarne might know.

In #1238, I updated https://github.com/jedisct1/libsodium/blob/master/packaging/dotnet-core/libsodium.pkgproj, I guess that's needed.

[rolfbjarne]

I don't know what changes are required to use an xcframework in a NuGet package.

There are two main ways:

1. Use a binding project, and reference the .xcframework in a NativeReference item. Then when doing dotnet pack the build will put the .xcframework in the right location.
2. Add the .xcframework (or the correct .framework for the tfm in question) in each the runtimes/ folder. In this case you can also zip up the .xcframework (so you have an .xcframework.zip file) - which is necessary to preserve symlinks if the .xcframework contains them.

[MartyIX]

@rolfbjarne Your second options looks like it just involves adding a line in

libsodium/packaging/dotnet-core/libsodium.pkgproj

Lines 28 to 37 in 7478140

	<Content Include="runtimes/win-x64/native/libsodium.dll" PackagePath="runtimes/win-x64/native/" />
	<Content Include="runtimes/win-x86/native/libsodium.dll" PackagePath="runtimes/win-x86/native/" />
	<Content Include="runtimes/linux-x64/native/libsodium.so" PackagePath="runtimes/linux-x64/native/" />
	<Content Include="runtimes/linux-arm/native/libsodium.so" PackagePath="runtimes/linux-arm/native/" />
	<Content Include="runtimes/linux-arm64/native/libsodium.so" PackagePath="runtimes/linux-arm64/native/" />
	<Content Include="runtimes/linux-musl-x64/native/libsodium.so" PackagePath="runtimes/linux-musl-x64/native/" />
	<Content Include="runtimes/linux-musl-arm/native/libsodium.so" PackagePath="runtimes/linux-musl-arm/native/" />
	<Content Include="runtimes/linux-musl-arm64/native/libsodium.so" PackagePath="runtimes/linux-musl-arm64/native/" />
	<Content Include="runtimes/osx-x64/native/libsodium.dylib" PackagePath="runtimes/osx-x64/native/" />
	<Content Include="runtimes/osx-arm64/native/libsodium.dylib" PackagePath="runtimes/osx-arm64/native/" />

, is that correct?

[rolfbjarne]

You'd need one line for each runtime identifier. If you want to support all the Apple ones: ios-arm64, iossimulator-arm64, iossimulator-x64, tvos-arm64, tvossimulator-arm64, tvossimulator-x64, maccatalyst-arm64 and maccatalyst-x64.

Note that the Mac Catalyst content inside the .xcframework will likely have symlinks, so I'd recommend creating an .xcframework.zip and use that instead of the directory itself.

[paulverbeke]

Anyone know how to add support for the Android platform to the NuGet package ?