Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate JDToaster #88

Open
jdisho opened this issue Sep 6, 2019 · 9 comments
Open

Integrate JDToaster #88

jdisho opened this issue Sep 6, 2019 · 9 comments

Comments

@jdisho
Copy link
Owner

jdisho commented Sep 6, 2019

Replace alerts with JDToaster.

@artyom2206
Copy link

Can I take it?

@jdisho
Copy link
Owner Author

jdisho commented Nov 21, 2019

Yes, you can, but let’s discuss it first in this issue @artyom2206.

@artyom2206
Copy link

artyom2206 commented Nov 22, 2019

So i installed it to Papr and implemented instead of each alertAction, but there is a problem with JDToaster on new IOS 13.2 version. When the toast shows from the bottom, then it disappears(check GIF). Toast duration also not works, I called it manually(IOS 12.4). Should I do pull request?

(https://user-images.githubusercontent.com/47772683/69388436-25c74e80-0cc9-11ea-935a-3855fe85161a.gif)

@jdisho
Copy link
Owner Author

jdisho commented Nov 22, 2019

This certainly does not look as I expected 🤔
Would you like to investigate the issue in the JDToaster and create a PR?

@artyom2206
Copy link

Ok, I will look at it

@jdisho
Copy link
Owner Author

jdisho commented Nov 28, 2019

Adding a strong reference to the UIWindow will solve the issue. @artyom2206

@jdisho
Copy link
Owner Author

jdisho commented Nov 29, 2019

The issue is fixed! I will do a release soon.

@Dishant10
Copy link

Hey @jdisho
Is this issue already fixed ? If not I'd like to contribute on that. Let me know at the earliest.

@jdisho
Copy link
Owner Author

jdisho commented Aug 4, 2022

I don't know if this is relevant. As you may see, I'm not maintaining this app anymore 😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants