Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide .ClangFormat for auto formatting #923

Open
LeonarddeR opened this issue Aug 17, 2023 · 2 comments · May be fixed by #940
Open

Provide .ClangFormat for auto formatting #923

LeonarddeR opened this issue Aug 17, 2023 · 2 comments · May be fixed by #940

Comments

@LeonarddeR
Copy link
Collaborator

When writing OSARA code, all of us format code manually as far as I can see.
I think adding a basic .ClangFormat file can be beneficial for us using an IDE that supports auto formatting with Clang, such as VS Code.

@jcsteh
Copy link
Owner

jcsteh commented Aug 17, 2023

Yeah, I think we should probably just re-format the whole code base and then fail the build if clang-format fails. Spending contributor or reviewer time on code formatting is silly. I just haven't had the time to come up with a clang-format settings file that minimises churn, since OSARA doesn't currently use one of the common styles, so we'll need to customise it a bit to avoid changing literally the entire code base. It'll also break any open pull requests, so we should try to get the ones we care about closed and kill the rest before we do it.

@jcsteh
Copy link
Owner

jcsteh commented Aug 17, 2023

I'd also ideally like to normalise some stuff with clang-tidy like braces for all condition blocks, nullptr instead of NULL, etc.

@LeonarddeR LeonarddeR linked a pull request Oct 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants