Check for user-supplied cache kwarg #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
- Coverage 79.19% 77.08% -2.12%
===========================================
Files 39 39
Lines 15377 15379 +2
===========================================
- Hits 12178 11855 -323
- Misses 3199 3524 +325
Continue to review full report at Codecov.
|
|
Unless I'm missing something, I'm not sure this patch will do anything, a function with the signature: will never have I.e. In [1]: def foo(cache=True, **kwargs):
...: print(cache, kwargs)
...:
In [2]: foo(**{'cache': False})
False {} |
|
ah yes, you are right. I made a simple mistake when testing this. Sorry, you can close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
simple fix to check for a user-supplied
cachekwarg.Sorry that this is showing so many commits. I let my fork get way out of date with the main develop branch, so all these commits were just me trying to get things back in consistency so I could make the (very simple) PR.