Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.4 changed transliteration behaviour #72

Open
tomjn opened this issue Jul 4, 2022 · 2 comments
Open

1.2.4 changed transliteration behaviour #72

tomjn opened this issue Jul 4, 2022 · 2 comments

Comments

@tomjn
Copy link

tomjn commented Jul 4, 2022

Upgrading from 1.2.3 to 1.2.4 broke our test suite, in particular some characters are transliterated differently, breaking assertions and semver.

E.g. we test that това е текст на бълрагски за тест becomes tova-e-tekst-na-blragski-za-test which is true in 1.2.3 and false in 1.2.4.

In 1.2.4 it instead transliterates to tova-e-tekst-na-bielragski-za-test.

urlify version in out
1.2.3 бълрагски blragski
1.2.4 бълрагски bielragski

I'm sure the dependency has its reasons for doing this, but composer pulled in 1.2.4 automatically and broke out test suites, this should have been a 1.3.0 or a 2.0.0 release.

@lux
Copy link
Collaborator

lux commented Jul 4, 2022

That was my bad on not bumping the version with this update. Apologies for breaking your tests without proper warning!

@tomjn
Copy link
Author

tomjn commented Jul 4, 2022

No worries, it was only 2 tests at the time, but it does mean we'll need to pin to 1.2.3 and do extra testing in case redirects cause issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants