Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of PHP's Transliterator class #51

Open
lux opened this issue Nov 5, 2017 · 3 comments
Open

Make use of PHP's Transliterator class #51

lux opened this issue Nov 5, 2017 · 3 comments

Comments

@lux
Copy link
Collaborator

lux commented Nov 5, 2017

We could extend character support by making use of PHP's Transliterator class. May even be faster too.
@voku
Copy link
Contributor

voku commented Sep 10, 2019

It's faster then regex but we are even faster, when we use a simple "str_replace()" 🙂 -> see e.g. https://github.com/voku/urlify/blob/master/src/voku/helper/URLify.php#L152

@lux
Copy link
Collaborator Author

lux commented Sep 10, 2019

I would love a PR for that if you're able to put one together.

@voku voku mentioned this issue Nov 22, 2019
Merged
@voku
Copy link
Contributor

voku commented Nov 23, 2019

You can now also test the Transliterator class, change "ASCII::to_transliterate" in the code and use the strict parameter. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lux @voku