Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two modules both copy in /usr/local/bin/s2i (jboss.container.maven.s2i and jboss.container.java.s2i.bash) #363

Open
jmtd opened this issue Jun 27, 2023 · 0 comments

Comments

@jmtd
Copy link
Member

jmtd commented Jun 27, 2023

In practice, it seems jboss.container.java.s2i.bash "wins". The copy in jboss.container.maven.s2i should be removed, and how we ended up in this situation explored.

For ubi9, the common files are modules/s2i/bash/artifacts/usr/local/s2i/assemble and modules/maven/s2i/artifacts/usr/local/s2i/assemble. Both were created when I copied in the cct_module contents (OPENJDK-112), and haven't been touched since. (in cct_module, they both date from CLOUD-2477 refactor maven modules and haven't been touched since.)

The maven module also copies in save-artifacts and the s2i module run, s2i-setup, and usage.

The same is true for ubi8.

The S2I copy is slightly more advanced.

The ideal solution would be for the modules to be merged, IMHO: there's no need for them to be separated for the OpenJDK container sources (it made more sense when other products might consume one of the two, but not both)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant