Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk-8-rhel8 vs. redhat-openjdk18-openshift imagestream diffs, user confusion #125

Open
gabemontero opened this issue Apr 22, 2020 · 6 comments

Comments

@gabemontero
Copy link

Hey @jmtd

We've had some user/customer confusion recently between those two imagestreams, and in particular some difficulty with openjdk-8-rhel8:1.2 (the latest tag) because it was still using v1 schema

conversely, the redhat-openjdk18-openshift:1.8 tag appears to be v2 schema

there are also questions coming in because of the "rhel8" name and whether they run on rhel7 (openshift still has to support rhel7 worker nodes) ... if that is the case, that would be an issue for openshift and installing that sample imagestream.

is openjdk-8-rhel8 more legacy and no longer being worked on? if so, can it be removed? if not, can we get an update with v2 schema?

when you get a sec let us know what is up ... thanks !!

@bparees FYI

@jmtd
Copy link
Member

jmtd commented Apr 29, 2020

Hi @gabemontero

conversely, the redhat-openjdk18-openshift:1.8 tag appears to be v2 schema

I'm not sure why we would have updated that image to the v2 schema and not the others. I can see no reason not to update them all to the v2 schema. I'll take a look at that in a sec.

is openjdk-8-rhel8 more legacy and no longer being worked on? if so, can it be removed? if not, can we get an update with v2 schema?

Quite the opposite. redhat-openjdk18-openshift is our oldest image, which is why the name is different to the scheme used by the other 3. It's JDK8 on top of RHEL7. openjdk-8-rhel8 is JDK8 on RHEL8. I would have to double-check the support matrix but I'm fairly sure we are supporting both the RHEL7-based and RHEL8-based images on OpenShift deployments on top of either RHEL7 or RHEL8.

Note that very shortly (today, or in the next couple of days) the *-rhel8 images will be renamed to ubi8/openjdk-XX, although the old names will continue to exist in the RHCC for a transition period. So I am going to update the metadata to reflect only the new names. This also means we can look at putting them in the community metadata, since the UBI images will be public and not requiring an RH account.

@jmtd
Copy link
Member

jmtd commented Apr 29, 2020

Re v1 versus v2 schema, by eyeball I can't see a difference in the form of those two image descriptions in the image stream metadata here; would it be possible to point me at the v2 schema documentation?

@jmtd
Copy link
Member

jmtd commented Apr 29, 2020

Here's my planned image streams update, FYI. I've tested this against openshift/library "make import"

https://github.com/jboss-container-images/openjdk/pull/126/files#diff-73b6623beeed7c1dd6bb73f34e0dc73c

@gabemontero
Copy link
Author

Re v1 versus v2 schema, by eyeball I can't see a difference in the form of those two image descriptions in the image stream metadata here; would it be possible to point me at the v2 schema documentation?

I'm the messenger here as much as anything else @jmtd

I think I'm sure that it has to do with the building of the image itself, not parts of the ImageStream yaml.

I'm tagging @bparees and @dmage from my team, who alerted me to this. Hopefully they can elaborate.

@bparees
Copy link

bparees commented Apr 29, 2020 via email

@jmtd
Copy link
Member

jmtd commented May 4, 2020

Hi @bparees

OK great. We will be merging a59bde2 imminently which should address this for the RHEL8-based images, at least. There are probably v1-schema tagged images for the RHEL7 branches remaining. I think we remove them in the near future (the older images cause problems for multiarch too, cc @yselkowitz). I'd been quite conservative about doing so up until now but I'm going to follow other image's lead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants