Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated TEMPLATE_DEBUG setting is required by sorl-thumbnail #476

Closed
philgyford opened this issue Dec 6, 2016 · 16 comments
Closed

Deprecated TEMPLATE_DEBUG setting is required by sorl-thumbnail #476

philgyford opened this issue Dec 6, 2016 · 16 comments

Comments

@philgyford
Copy link

The TEMPLATE_DEBUG setting which was deprecated in Django 1.8 and 1.9, and is missing from 1.10's docs (so I assume it's now obsolete) is required by sorl-thumbnail.

Without a TEMPLATE_DEBUG setting I get this when I try and use the {% thumbnail ... %} tag in a template:

'Settings' object has no attribute 'TEMPLATE_DEBUG'

If I add it to my settings, the template tag works.

@dimitry
Copy link

dimitry commented Dec 11, 2016

Try installing directly from Github (add to requirements.txt):
-e git+https://github.com/mariocesar/sorl-thumbnail.git#egg=sorl-thumbnail

Looks like latest version on pip is 12.4a1 and doesn't reflect Django 1.10 changes.

@bfincher
Copy link

Are there any plans on getting a new version uploaded to pip?

RevolutionTech added a commit to RevolutionTech/perdiem-django that referenced this issue Jan 24, 2017
(ie. hash 7e61948e7a987714097ba50a54120f584db9c843)
at least until
jazzband/sorl-thumbnail#476 (comment)
is addressed
@Flimm
Copy link
Contributor

Flimm commented Feb 14, 2017

I would also appreciate a new version on Pypi.

@idrummer83
Copy link

I have the same trouble

@PetrDlouhy
Copy link

@mariocesar Could you please update the PyPI package?

@mariocesar
Copy link
Collaborator

Tests are not passing for te master branch, it needs first to pass and take care of that.

Hope to have the time soon , however anyone is welcome to give it look and commit

@pixelead0
Copy link

Please update the PyPi package.

@SalahAdDin
Copy link

Please update it.

@Flimm
Copy link
Contributor

Flimm commented Jun 21, 2017

sorl-thumbnail is now part of Jazz Band, anyone can join and contribute fixes, and a new version on PyPI should be released automatically if the tests pass.

@adi-
Copy link

adi- commented Sep 1, 2017

WHy this is closed?! Issue is not fixed

@Flimm
Copy link
Contributor

Flimm commented Sep 1, 2017

@adi- This issue is not closed. As you can see at the top of the page, this issue is still open.

@adi-
Copy link

adi- commented Sep 1, 2017

Damn, I have looked at the status two comments above. Sorry.

@olymk2
Copy link

olymk2 commented Sep 4, 2017

just hit this myself, with latest django any chance of an updated package any time soon on pip ?

@Flimm
Copy link
Contributor

Flimm commented Sep 4, 2017

@olymk2 A new version on PyPI is waiting on @jazzband/roadies or @mariocesar, as they are the only ones who have access to the PyPI package. See #507 and jazzband/help#69 .

@Q-back
Copy link

Q-back commented Oct 17, 2017

@dimitry your method doesn't work for me :( Django 1.11

@camilonova
Copy link
Member

Just released. https://pypi.python.org/pypi/sorl-thumbnail/12.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests