Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.8 support #948

Closed
atugushev opened this issue Oct 17, 2019 · 4 comments · Fixed by #956
Closed

Add python 3.8 support #948

atugushev opened this issue Oct 17, 2019 · 4 comments · Fixed by #956
Assignees
@hramezani
Labels
enhancement Improvements to functionality good first issue A good item for first time contributors to work on maintenance Related to maintenance processes

Comments

@atugushev
Copy link
Member

What's the problem this feature will solve?

Python 3.8 is released, so it's time to support it.

Describe the solution you'd like

  1. add "py37" env to tox.ini
  2. remove 3.8-dev from .travis.yml
  3. add "Programming Language :: Python :: 3.8" classifier to setup.py
  4. add "3.8" dimension to .travis.yml (supported, see https://travis-ci.community/t/add-python-3-8-support/5463)
  5. add "py37" dimension to .appveyor.yml (not supported yet, but will be on the nex image update, tracking issue: Python 3.8.0 appveyor/ci#3142)
  6. add "3.8" to python-version list in .github/workflows/cron.yml (not supported yet, tracking issue: Add Python 3.8 support actions/setup-python#30)

Alternative Solutions

N/A

Additional context

https://discuss.python.org/t/python-3-8-0-is-now-available/2478
@atugushev atugushev added PR wanted Feature is discussed or bug is confirmed, PR needed maintenance Related to maintenance processes good first issue A good item for first time contributors to work on labels Oct 17, 2019
@hramezani
Copy link
Member

@atugushev I can work on this.

@atugushev
Copy link
Member Author

Thanks, @hramezani! Appreciate it.

@atugushev atugushev added the enhancement Improvements to functionality label Oct 21, 2019
@hramezani hramezani mentioned this issue Oct 21, 2019
Merged
2 tasks
@atugushev atugushev removed the PR wanted Feature is discussed or bug is confirmed, PR needed label Oct 21, 2019
@hugovk
Copy link
Member

hugovk commented Nov 9, 2019

🚀 Python 3.8 is now available on AppVeyor:

@atugushev
Copy link
Member Author

@hugovk Yeah! Finally, all opened issues are closed 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hramezani hramezani

Labels
enhancement Improvements to functionality good first issue A good item for first time contributors to work on maintenance Related to maintenance processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python 3.8 support hramezani/pip-tools
3 participants
@hugovk @hramezani @atugushev