Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explicitly which price includes tax and which not #225

Open
PetrDlouhy opened this issue Aug 7, 2020 · 0 comments
Open

Specify explicitly which price includes tax and which not #225

PetrDlouhy opened this issue Aug 7, 2020 · 0 comments

Comments

@PetrDlouhy
Copy link
Contributor

There are few places, where the price or it's tax is set for the payment:

  • Payment.total
  • Payment.tax
  • PurchasedItem.price

It is not entirely clear from the docs, if the prices includes tax or not and if the tax is tax amount or tax rate.
From the implementation of PayPal provider, it is clear, that both prices should be without tax.

I would like to prevent situation, where every provider has it's own interpretation of the values and thus they are incompatible.

I also realised, that the provided information is not enough for my PayU provider, because PayU requires prices for the items to include the tax. I can also imagine provider, that requires tax rate to be stated for every item separately. This problem I solve in PR #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant