Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Label used from Newsletter class instead of instance #330

Open
frennkie opened this issue Sep 21, 2020 · 1 comment · May be fixed by #331
Open

App Label used from Newsletter class instead of instance #330

frennkie opened this issue Sep 21, 2020 · 1 comment · May be fixed by #331

Comments

@frennkie
Copy link
Collaborator

frennkie commented Sep 21, 2020 •
edited

I'm having problems subclassing NewsletterAdmin. I have a app called myapp, but when I subclass the admin classes then instead of e.g. myapp.subscription the reverse match is always attempted for newsletter.subscription.

I think the problem is that the code uses model._meta.app_label instead of obj._meta.app_label
@frennkie
Copy link
Collaborator Author

I have the same issue with: https://github.com/dokterbob/django-newsletter/blob/57ac58df4e6049d30e4b9871a31e738d79fc7bb4/newsletter/admin.py#L93 (should be opts = obj._meta)

@frennkie frennkie linked a pull request Sep 22, 2020 that will close this issue
Open
@frennkie frennkie changed the title App Label from model instead of obj App Label used from Newsletter class instead of instance Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use object instance when getting _meta info in admin frennkie/django-newsletter
1 participant
@frennkie