Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about npt simulation #294

Open
Chenghao-Wu opened this issue Dec 1, 2023 · 2 comments
Open

Question about npt simulation #294

Chenghao-Wu opened this issue Dec 1, 2023 · 2 comments

Comments

@Chenghao-Wu
Copy link

Hi JAX-MD developers,

I noticed that in the notebook: npt_simulation, it states that "For now NPT simulations must be performed with fractional coordinates, where the atom positions are stored in the unit cube. This restriction can likely be relaxed in the future, if it were desirable."

Is it still true for the latest version?

@sschoenholz
Copy link
Collaborator

Yeah, it's still true. The basic reason is that it's more challenging to resize the unit cell if atom positions are not stored fractionally. I'm sure it's possible to do this by e.g. projecting into the unit cube and then back into the new space, but it's a bit tricky to get right.

@Chenghao-Wu
Copy link
Author

Thank you very much for your reply. It is very useful. I was using unfractional coordinate to run NPT simulation. The results look a bit strange and later I found this statement. I will adjust accordingly. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants