Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Japanese text to English #34

Open
miya0001 opened this issue Jul 8, 2017 · 6 comments
Open

Translate Japanese text to English #34

miya0001 opened this issue Jul 8, 2017 · 6 comments

Comments

@miya0001
Copy link
Contributor

miya0001 commented Jul 8, 2017

If we get a pull-request written in another languages that can't be understood by us, It will be difficult to merge it.

So I want to unify the language to English and translate Japanese text in the CSV to Engish.
I think this will make Japanese Wapuus well-known in the World.

How do you think?

@tekapo
Copy link
Contributor

tekapo commented Jul 9, 2017

How about both in his/her language and English?
Example:
Your lang / Eng
би Pooh / Wapuu
わぷー / Wapuu

@tecking
Copy link

tecking commented Jul 10, 2017

How about both in his/her language and English?

That's a good idea! :)

@hideokamoto
Copy link

I thinks wapuu.name should be only one language.

How about to add new columns like wapuu.name.${Language} or wapuu.name_translated ?

Example:

{
  "name": "original-wapuupng",
  "wapuu": {
    "name": "Wapuu",
    "url": "https://ja.wordpress.org/",
    "repository": "https://github.com/jawordpressorg/wapuu",
    "src": "https://jawordpressorg.github.io/wapuu/wapuu-archive/original-wapuu.png",
    "mime_type": "image/png",
    "name_translated": {
        "English": "Wapuu",
        "Japanese": "わぷー"
    }
  },
  "author": {
    "name": "Kazuko Kaneuchi",
    "url": "https://twitter.com/mutsuking"
  },
  "description": "Original Wapuu"
}

@hereliesvince
Copy link

hereliesvince commented Jul 10, 2017

Throwing another idea into the hat. What about keeping it much more generic and having "English" and "Native"?

  "name": "original-wapuupng",
  "wapuu": {
    "name": "Wapuu",
    "url": "https://ja.wordpress.org/",
    "repository": "https://github.com/jawordpressorg/wapuu",
    "src": "https://jawordpressorg.github.io/wapuu/wapuu-archive/original-wapuu.png",
    "mime_type": "image/png",
    "name_translated": {
        "english": "Wapuu",
        "native": "わぷー"
    }
  },
  "author": {
    "name": "Kazuko Kaneuchi",
    "url": "https://twitter.com/mutsuking"
  },
  "description": "Original Wapuu"
}

@easilyamused
Copy link

I like all the ideas and see room for improvement. We have wapuus from all over the world. Whatever we can do to support them would be great.

I feel a little bad about putting English first. The "native" is a nice way to support many languages.
Would worry about syncing the Wapuu-API with the 2nd key in name_translated changing with every new language.

Thanks for all the hard work!

@tekapo
Copy link
Contributor

tekapo commented Jul 11, 2017

Agree with @easilyamused . I like the "native" name first too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants