Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numeric and money should only allow ${number} like Int8String #151

Open
felixfbecker opened this issue May 6, 2023 · 0 comments
Open

numeric and money should only allow ${number} like Int8String #151

felixfbecker opened this issue May 6, 2023 · 0 comments

Comments

@felixfbecker
Copy link

felixfbecker commented May 6, 2023

money currently accepts string | number in Insertables and returns string in Selectables.
numeric, which is a fixed-decimal type just like money, currently only accepts number (resulting in potential loss of precision) and returns number in Selectables (which is incorrect).

These should both return a db.NumericString that is defined like below (just like Int8String already does) and both accept db.NumericString | number on input.

type NumericString = `${number}`
@felixfbecker felixfbecker changed the title numeric and money should only allow \${number}\` like Int8String` numeric and money should only allow ${number} like Int8String May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant