Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database config requires at least one key even though pg.Pool() does not require at least one key #134

Open
maxweisel opened this issue Nov 17, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@maxweisel
Copy link

All of the postgres connections in my project fall back to the PG*** environment variables for their connection. I'd love to use that with Zapatos however the docs say that the zapatosconfig "db" key is required, and it seems passing an empty object is not sufficient. Would it be possible to drop the requirement on passing a "db" object with a connectionString key?

Max

@jawj jawj self-assigned this Nov 21, 2022
@jawj
Copy link
Owner

jawj commented Nov 21, 2022

This sounds very sensible. It's now on my list.

@jawj jawj added the enhancement New feature or request label Nov 21, 2022
@maxweisel
Copy link
Author

Thank you!! I really appreciate it.

@ssadler
Copy link

ssadler commented Apr 18, 2023

If anyone comes across this issue (as I did), the answer for me was in the docs:

https://jawj.github.io/zapatos/#environment-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants