Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow() and dontAllow() shouldn't run be called on a background thread #26

Open
franciscofranco opened this issue May 4, 2017 · 0 comments

Comments

@franciscofranco
Copy link

As the title explicitly says, those callbacks shouldn't be posted on a background thread. You can either give it the option to be posted to a bg thread or simply post it on the main thread. It's slightly annoying when doing UI operations on a custom allow()/dontAllow() and then getting exceptions warning about "Only the original thread that created a view hierarchy can touch its views." and then having to wrap everything inside a main looper. At least give them the @workerthread annotation so that we know what kind of thread they're being posted on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant